16394 add ack functionality #16552
16394 add ack functionality #16552
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
| val ackMsh = outgoingAck.msh | ||
| ackMsh.msh1_FieldSeparator.value = "|" | ||
| ackMsh.msh2_EncodingCharacters.value = "^~\\&" | ||
| ackMsh.msh3_SendingApplication.parse("ReportStream") |
There was a problem hiding this comment.
I took these values directly from the Spec document so just double check that these are exactly what we want.
There was a problem hiding this comment.
Looks good and works well. I tested a few different scenarios: different message types (ORU), missing fields that should populate certain values in the response (MSH.3/MSH.4), and setting MSH.15 to AL when a fully populated message is sent. In each scenario the ACK response was correctly populated.
|
@arnejduranovic
|
…portstream into platform/jamie/16394-ack
| every { mockActionHistory.action } returns mockAction | ||
| every { mockAction.actionId } returns 5 | ||
| every { mockEngine.db } returns mockDb | ||
| // I don't agree with ktlint on this one |
There was a problem hiding this comment.
LOL I've seen some odd looking ktlint rules before. This takes the cake.
|
I tested locally with the test data in the PR description and got this response when I set the @brick-green FYI |
…portstream into platform/jamie/16394-ack
prime-router/src/main/kotlin/fhirengine/translation/hl7/utils/HL7ACKUtils.kt
Show resolved
Hide resolved
…portstream into platform/jamie/16394-ack
|
This PR adds ACK functionality to the waters and report submission endpoints.
Test Steps:
Changes
Checklist
Testing
./prime testor./gradlew testSmokeagainst local Docker ReportStream container?Linked Issues