Skip to content

remove usage of downloadjs#16595

Merged
etanb merged 2 commits intomainfrom
experience/16309/hl7-download-character-bug
Nov 20, 2024
Merged

remove usage of downloadjs#16595
etanb merged 2 commits intomainfrom
experience/16309/hl7-download-character-bug

Conversation

@etanb
Copy link
Copy Markdown
Collaborator

@etanb etanb commented Nov 19, 2024

This PR removes our usage of downloadjs which is a long-ago deprecated library that can be replicated by native JS functions.

Fixes #16309

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 19, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

frontend-react/package.json
  • @types/downloadjs@^1.4.6
  • downloadjs@^1.4.7
frontend-react/yarn.lock
  • @types/downloadjs@1.4.6
  • downloadjs@1.4.7

@etanb etanb added trialfrontend03 Trigger a trialfrontend03 deployment experience Team label to flag issues owned by the Experience Team labels Nov 19, 2024
@github-actions
Copy link
Copy Markdown
Contributor

Branch deployed to Chromatic 🚀.

  • ⚠️ Detected 0 tests with visual changes.
  • ✅ All tests passed.

View via:

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
30.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Broken Links ⚠️

https://www.cdc.gov/od/foia

Error: Request failed with status code 403


https://www.hhs.gov/vulnerability-disclosure-policy/index.html

Error: Request failed with status code 403


https://www.cdc.gov/poxvirus/mpox/lab-personnel/report-results.html

Error: Request failed with status code 404


Copy link
Copy Markdown
Collaborator

@jpandersen87 jpandersen87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@etanb etanb merged commit 448460a into main Nov 20, 2024
@etanb etanb deleted the experience/16309/hl7-download-character-bug branch November 20, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

experience Team label to flag issues owned by the Experience Team trialfrontend03 Trigger a trialfrontend03 deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Downloading a HL7 file from Daily Data garbles the 'µ' character in the content of the file

2 participants