Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-skip E2E test: receiver-status-page-user-flow.spec.ts #16603

Conversation

jpandersen87
Copy link
Collaborator

@jpandersen87 jpandersen87 commented Nov 19, 2024

Fixes #16061

This PR unskips smoke tests in receiver-status-page-user-flow.

  • testing logic inside the page class was updated to properly take filtering into account which simplifies logic inside tests.
  • functionality test for success type select refactored
  • react element key updated for org/receiver rows to also include receiver id (fix staging returning two receiver ids using the same receiver name)
  • functionality test for receiver name updated to try wait for the receiver status rows count to match what's expected rather than one-time assert (to allow time for data retrieval and page update)

@jpandersen87 jpandersen87 requested review from a team as code owners November 19, 2024 20:09
@jpandersen87 jpandersen87 self-assigned this Nov 19, 2024
@jpandersen87 jpandersen87 changed the base branch from master to main November 19, 2024 20:11
Copy link

github-actions bot commented Nov 19, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@jpandersen87 jpandersen87 enabled auto-merge (squash) November 22, 2024 21:15
Copy link

Branch deployed to Chromatic 🚀.

  • ⚠️ Detected 0 tests with visual changes.
  • ✅ All tests passed.

View via:

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
76.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@jpandersen87 jpandersen87 merged commit 4869b13 into main Nov 22, 2024
29 of 32 checks passed
@jpandersen87 jpandersen87 deleted the experience/16061-Un-skip-E2E-test-receiver-status-page-user-flowspects branch November 22, 2024 21:25
Copy link

⚠️ Broken Links ⚠️

https://www.cdc.gov/od/foia

Error: Request failed with status code 403


https://www.hhs.gov/vulnerability-disclosure-policy/index.html

Error: Request failed with status code 403


https://www.cdc.gov/poxvirus/mpox/lab-personnel/report-results.html

Error: Request failed with status code 404


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Un-skip E2E test: receiver-status-page-user-flow.spec.ts
3 participants