Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added member oid extension for each observation #16615

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added member oid extension for each observation #16615

wants to merge 2 commits into from

Conversation

kant777
Copy link
Collaborator

@kant777 kant777 commented Nov 20, 2024

This PR adds the member OID as the extension to all observations in the elr messages.

Test Steps:

  1. Include steps to test these changes

image

Changes

  • The ConditionStamper will now handle both condition lookups and Member OID stamping based on the logic and constants from ObservationMappingConstants

Checklist

Testing

  • Tested locally? yes
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container? yes
  • Added tests? yes

Linked Issues

@kant777 kant777 requested a review from a team as a code owner November 20, 2024 19:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@kant777 kant777 requested a review from mkalish November 20, 2024 19:17
@kant777 kant777 closed this Nov 20, 2024
@kant777 kant777 reopened this Nov 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

Test Results

1 249 tests  +1   1 245 ✅ +1   7m 50s ⏱️ +22s
  162 suites ±0       4 💤 ±0 
  162 files   ±0       0 ❌ ±0 

Results for commit d14dae0. ± Comparison against base commit 62207ec.

♻️ This comment has been updated with latest results.

@kant777 kant777 mentioned this pull request Nov 20, 2024
Closed
3 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 20, 2024 •
edited
Loading

Integration Test Results

 57 files  ±0   57 suites  ±0   39m 22s ⏱️ -15s
421 tests ±0  411 ✅ ±0  10 💤 ±0  0 ❌ ±0 
424 runs  ±0  414 ✅ ±0  10 💤 ±0  0 ❌ ±0 

Results for commit d14dae0. ± Comparison against base commit 62207ec.

♻️ This comment has been updated with latest results.

@jack-h-wang jack-h-wang added the platform Platform Team label Nov 20, 2024
@mkalish mkalish removed their request for review November 20, 2024 20:10
@arnejduranovic arnejduranovic self-assigned this Nov 20, 2024
@kant777 kant777 force-pushed the platform/kant/14511-add-test-member-oid-extension branch from 7023bfc to 0edf955 Compare December 3, 2024 10:32
@kant777 kant777 requested a review from a team as a code owner December 3, 2024 10:32
@kant777 kant777 force-pushed the platform/kant/14511-add-test-member-oid-extension branch 2 times, most recently from 0edf955 to 7023bfc Compare December 3, 2024 10:46
@kant777 kant777 force-pushed the platform/kant/14511-add-test-member-oid-extension branch from 7023bfc to d14dae0 Compare December 4, 2024 21:19
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnejduranovic arnejduranovic Awaiting requested review from arnejduranovic

At least 1 approving review is required to merge this pull request.

Assignees

@arnejduranovic arnejduranovic

Labels
platform Platform Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Map CSTE Member OID to member-oid extension during convert-step
3 participants
@kant777 @arnejduranovic @jack-h-wang