Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16722 authz documentation #16769

Merged
merged 8 commits into from
Dec 16, 2024
Merged

16722 authz documentation #16769

merged 8 commits into from
Dec 16, 2024

Conversation

jalbinson
Copy link
Collaborator

@jalbinson jalbinson commented Dec 10, 2024

This PR documents our current authorization system.

Test Steps:

  1. None

Changes

  • Authorization document
  • Unit test for my own understanding of scope mapping

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • (For Changes to /frontend-react/...) Ran npm run lint:write?
  • Added tests?

Linked Issues

Copy link
Contributor

github-actions bot commented Dec 10, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

github-actions bot commented Dec 11, 2024

Test Results

1 268 tests  +1   1 264 ✅ +1   8m 6s ⏱️ +16s
  164 suites ±0       4 💤 ±0 
  164 files   ±0       0 ❌ ±0 

Results for commit da5e6d8. ± Comparison against base commit ab4081f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 11, 2024

Integration Test Results

 60 files   60 suites   38m 50s ⏱️
424 tests 414 ✅ 10 💤 0 ❌
427 runs  417 ✅ 10 💤 0 ❌

Results for commit da5e6d8.

♻️ This comment has been updated with latest results.

@jalbinson jalbinson marked this pull request as ready for review December 16, 2024 16:21
@jalbinson jalbinson requested a review from a team as a code owner December 16, 2024 16:21
| `md-phd.*.report` | Organization Report Submitter for md-phd |
| `md-phd.default.admin` | Organization Administrator for md-phd |
| `md-phd.default.user` | Organization User for md-phd |
| `md-phd.default.report` | Organization Report Submitter for md-phd |
Copy link
Collaborator

@arnejduranovic arnejduranovic Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, there is functionally no difference between 'default' and 'abc'. 'default' is nothing special and literally means "a sender/receiver named 'default'" and 'abc' means "a sender/receiver named 'abc'"

'default' is seen a lot for SENDER names. I believe there is a way to create a sender when if you don't specify a sender name is just uses 'default'. There are/were issues with front-end code treating 'default' extraordinarily which caused bugs/limited functionality.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prime-router/docs/authz/authz-deprecated-implementation.md Outdated Show resolved Hide resolved
Copy link

@jalbinson jalbinson merged commit 288a70d into main Dec 16, 2024
25 checks passed
@jalbinson jalbinson deleted the platform/jamie/16722-authz-docs branch December 16, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform Platform Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document current authorization implementation
2 participants