Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some missing transforms from azure and fixing Message Testing API #16777

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

victor-chaparro
Copy link
Collaborator

This PR fixes some bugs on the message testing API and adds some transforms that were missing from azure.

If you are suggesting a fix for a currently exploitable issue, please disclose the issue to the prime-reportstream team directly outside of GitHub instead of filing a PR, so we may immediately patch the affected systems before a disclosure. See SECURITY.md/Reporting a Vulnerability for more information.

Test Steps:

  1. Use this postman collection to test changes to API
    Message Testing.postman_collection.json

Changes

  • Fixes message testing API

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • (For Changes to /frontend-react/...) Ran npm run lint:write?
  • Added tests?

@victor-chaparro victor-chaparro requested a review from a team as a code owner December 11, 2024 01:11
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link
Contributor

Test Results

1 255 tests  ±0   1 251 ✅ ±0   7m 41s ⏱️ -7s
  164 suites ±0       4 💤 ±0 
  164 files   ±0       0 ❌ ±0 

Results for commit bceb9a0. ± Comparison against base commit 164926e.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Contributor

Integration Test Results

 59 files   59 suites   38m 27s ⏱️
423 tests 413 ✅ 10 💤 0 ❌
426 runs  416 ✅ 10 💤 0 ❌

Results for commit bceb9a0.

@victor-chaparro victor-chaparro merged commit e8025be into main Dec 11, 2024
24 of 25 checks passed
@victor-chaparro victor-chaparro deleted the engagement/fixed-message-testing-api branch December 11, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants