Set Hikari connection timeout to 60 seconds #17429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
arnejduranovic
temporarily deployed
to
staging
GitHub Actions
Inactive
Integration Test Results 60 files 60 suites 43m 40s ⏱️ Results for commit fa7815c. ♻️ This comment has been updated with latest results. |
victor-chaparro
approved these changes
Feb 27, 2025
arnejduranovic
temporarily deployed
to
staging
GitHub Actions
Inactive
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where Hikari config was not respecting the value of 60000ms for the connection timeout. It is also the hope that this change helps address the issue described in the following incident report: https://cdc.sharepoint.com/:w:/r/teams/ReportStream/_layouts/15/Doc.aspx?sourcedoc=%7B2E1169CA-B921-4CAA-B0E6-2BEF7443A1D7%7D&file=2025_02_18%20-%20Database%20Connectivity%20Issues.docx&action=default&mobileredirect=true
Test Steps: