Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish validation of the new dockerization of FE to eliminate 404 error #17453

Conversation

jpandersen87
Copy link
Collaborator

Fixes #17435

This PR adds proxying to the staging api through the /api url for the docker nginx server. This is for internal use only (running locally), as in deployed environments this redirection is handled at a higher level so our nginx server is never queried at this url in practice.

@jpandersen87 jpandersen87 self-assigned this Feb 28, 2025
Copy link
Contributor

github-actions bot commented Feb 28, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

…w-dockerization-of-FE-to-eliminate-404-error
Copy link
Contributor

Branch deployed to Chromatic 🚀.

  • ⚠️ Detected 0 tests with visual changes.
  • ✅ All tests passed.

View via:

Copy link
Contributor

⚠️ Broken Links ⚠️

https://www.cdc.gov/about/default.htm

Error: Request failed with status code 404


https://www.hhs.gov/vulnerability-disclosure-policy/index.html

Error: Request failed with status code 403


❌ /assets/xlsm/20241204_ReportStream-Mapping-Template.xlsm

Error: Internal link: Page error


https://www.cdc.gov/poxvirus/mpox/lab-personnel/report-results.html

Error: Request failed with status code 404


Copy link
Collaborator

@devopsmatt devopsmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nginx.conf code looks good to me.

@jpandersen87 jpandersen87 merged commit 0aa8beb into main Feb 28, 2025
33 checks passed
@jpandersen87 jpandersen87 deleted the experience/17435-Finish-validation-of-the-new-dockerization-of-FE-to-eliminate-404-error branch February 28, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finish validation of the new dockerization of FE to eliminate 404 error
2 participants