remove usa-skipnav from touchpoints-skipnav #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: elisa lee <[email protected]>
3 tasks
fzhao99
approved these changes
Sep 8, 2023
emyl3
reviewed
Sep 8, 2023
assets/js/touchpoints.js
Outdated
| @@ -406,7 +406,7 @@ function FBAform(d, N) { | |||
| }, | |||
| loadFeebackSkipLink: function () { | |||
| this.skipLink = document.createElement("a"); | |||
| this.skipLink.setAttribute("class", "usa-skipnav touchpoints-skipnav"); | |||
There was a problem hiding this comment.
I'm wondering if instead of removing it from this file... in the sr-touchpoints.js file we remove the usa-skipnav class
const feedbackSkipLink = document.querySelector(".touchpoints-skipnav");
feedbackSkipLink.classList.remove("usa-skipnav");
so it is easier to maintain in the future? 🤔
There was a problem hiding this comment.
I think it makes sense. The comment on top of the file says it was just copied from a different place. It would be possible that it just gets deleted here by accident.
/**
* Script taken from our touchpoints configuration here: https://touchpoints.app.cloud.gov/touchpoints/2a6e9509.js
* NOTE: When updating script ensure sr-touchpoints.js works as intended
*/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue or Background Info
Changes Proposed
Additional Information
Testing