Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bob/remove unused gem #640

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Bob/remove unused gem #640

merged 2 commits into from
Jan 10, 2024

Conversation

fzhao99
Copy link
Contributor

@fzhao99 fzhao99 commented Jan 8, 2024

Removes the html-pipeline gem that I don't think we're using anywhere. We don't have any Ruby code in the static site, which makes me think the gem might have been made obsolete at some point after another part of the static site got taken out.

Deployed to dev4 for testing. Do a basic smoke test and verify nothing is broken

Testing

  • Includes a summary of what a code reviewer should verify

dependabot bot and others added 2 commits January 2, 2024 21:06
Bumps [html-pipeline](https://github.com/gjtorikian/html-pipeline) from 2.14.3 to 3.0.1.
- [Release notes](https://github.com/gjtorikian/html-pipeline/releases)
- [Changelog](https://github.com/gjtorikian/html-pipeline/blob/main/CHANGELOG.md)
- [Commits](gjtorikian/html-pipeline@v2.14.3...v3.0.1)

---
updated-dependencies:
- dependency-name: html-pipeline
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it doesn't seem to be used anywhere! Thank you for removing! Smoke tested on dev4 LGTM!

@fzhao99 fzhao99 merged commit 2d1a189 into main Jan 10, 2024
7 checks passed
@fzhao99 fzhao99 deleted the bob/remove-unused-gem branch January 10, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants