Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copy and screenshot to show that we support multiple diseases #664

Merged
merged 6 commits into from
Mar 6, 2024

Conversation

bobbywells52
Copy link
Collaborator

@bobbywells52 bobbywells52 commented Mar 1, 2024

Related Issue or Background Info

#7283

Changes Proposed

Update copy and screenshot on landing page.

Additional Information

The original COVID only screenshot that we use is framed in blue as seen here.
However, the new screenshot does not have this framing. When I swapped out the screenshots, the new one without the blue framing looks a little rough and not as clean. @jayna-SkylightDigital and @kenieh what are your thoughts on adding the blue framing to our new multi-disease screenshot?

Screenshots / Demos

Screenshot 2024-03-04 at 12 52 50 PM Screenshot 2024-03-04 at 12 52 57 PM

Design

  • Any UI/UX changes have a designer as a reviewer, and changes have been approved

Testing

  • Deployed to dev 4

@bobbywells52 bobbywells52 marked this pull request as ready for review March 4, 2024 19:55
@bobbywells52 bobbywells52 changed the title Bobby/7283 Update copy and screenshot to show that we support multiple diseases Mar 4, 2024
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment code-wise.

pages/home.md Show resolved Hide resolved
@bobbywells52 bobbywells52 requested a review from emyl3 March 5, 2024 17:05
Copy link
Collaborator

@emyl3 emyl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise!

@mpbrown
Copy link
Collaborator

mpbrown commented Mar 6, 2024

@bobbywells52 here's an updated image I edited to have the same blue border as before

sr-test-card-queue

@kenieh
Copy link
Collaborator

kenieh commented Mar 6, 2024

Hi! Sorry, just getting to and reading this. I designed the screenshot for this a while ago and attached the figma link to one of the tickets... not sure if it got lost in translation.

https://www.figma.com/file/LglkDsGZDKMZm3XCkJPhfR/SimpleReport-2023%2B?type=design&node-id=4849%3A14917&mode=dev&t=3N2gqn7HZ5NLTNeS-1

Lmk if that works and you're able to download that image to use. It's slightly different from Mike's design as it has an inner drop shadow to add some more depth/realism. But I really appreciate your initiative on this Mike!

Copy link
Collaborator

@mpbrown mpbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bobbywells52
Copy link
Collaborator Author

bobbywells52 commented Mar 6, 2024

Image has been updated to one that Kenny provided and is now live for review in Dev 4

@bobbywells52 bobbywells52 merged commit e6412d7 into main Mar 6, 2024
7 checks passed
@bobbywells52 bobbywells52 deleted the bobby/7283 branch March 6, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants