Update /waitlist/ to include supported diseases / interest checkboxes #671
Conversation
DanielSass
requested review from
kenieh,
mehansen,
emyl3,
mpbrown,
fzhao99 and
bobbywells52
formatting add additional-conditions section add new fiels to form logic cleanup design feedback data flow working
some changes to take advantage of the disease-config work we did for the site audit in the waitlist form --------- Co-authored-by: wellsbobby52 <[email protected]> Co-authored-by: Daniel Sass <[email protected]>
pages/forms/waitlist-form.html
Outdated
| @@ -77,11 +77,34 @@ <h1 class="font-heading-xl text-primary-darker">{{ page.title }}</h1> | |||
| type="text" | |||
| required | |||
| /> | |||
| <p> Currently, SimpleReport helps facilities report results for:</p> | |||
|
|
|||
| {% include content/supported-diseases.html styles="padding-left-205" %} | |||
There was a problem hiding this comment.
.padding-left-205 is a USWDS style that we can take advantage of to add the same amount of padding as the inline version of it. Electing to use a class here so that we can chain off the styles variable in the snippet in supported-diseases.html.
| @@ -1,7 +1,5 @@ | |||
| <ul> | |||
| <ul class={{include.styles}}> | |||
There was a problem hiding this comment.
the include.styles here uses Jekyll's feature to pass params down to include blocks.. This mean that we can add styles as needed to the parent ul class in the future by using
{% include content/supported-diseases.html styles="[CLASS-NAME-TO-ADD]" %}
can also extend this as needed for the list elements.
| "referral", | ||
| ]; | ||
|
|
||
| const fieldsToCheck = Array.from(document.getElementsByClassName("form-input")) |
There was a problem hiding this comment.
the form input classes were added to the waitlist forms that mattered so that we can grab all of them together using getElementsByClassName
There was a problem hiding this comment.
I think we want to do the backend changes first right? Places to update from the top of my head are:
https://github.com/CDCgov/prime-simplereport/blob/3c665d4f3b7b53eb94d275ff51c12e42b4c5ad54/backend/src/main/java/gov/cdc/usds/simplereport/api/model/accountrequest/WaitlistRequest.java#L11
https://github.com/CDCgov/prime-simplereport/blob/3c665d4f3b7b53eb94d275ff51c12e42b4c5ad54/backend/src/main/resources/templates/waitlist-request.html#L4
I don't think this information will go anywhere without updating the above. I didn't see a ticket for that work though 👀
I don't think that there is any backend ticket as of now |
|
corresponding backend issue has been opened here: CDCgov/prime-simplereport#7465 |
Related Issue or Background Info
Changes Proposed
Additional Information
deployed on dev3
Screenshots / Demos
Screen.Recording.2024-03-20.at.2.32.42.PM.mov
Checklist for Author and Reviewer
Design
test,dev, orpentestand smoke-tested by both the engineering and design teamsContent
Support
Testing