Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade node to version 20 #682

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Upgrade node to version 20 #682

merged 1 commit into from
Apr 16, 2024

Conversation

emyl3
Copy link
Collaborator

@emyl3 emyl3 commented Apr 11, 2024 •
edited
Loading

Related Issue or Background Info

Changes Proposed

  • Update to node version 20 in documentation and throughout codebase

Additional Information

Screenshots / Demos

  • N/A

Checklist for Author and Reviewer

Testing

  • Check the app works locally as expected
  • Smoke test the app on dev3 as make sure it works as expected
  • Check any GH actions that rely on node work as expected
  • Check any package.json scripts run as expected

@emyl3 emyl3 marked this pull request as ready for review April 11, 2024 20:54
fzhao99
fzhao99 approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@fzhao99 fzhao99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@emyl3 emyl3 mentioned this pull request Apr 15, 2024
Closed
4 tasks
@emyl3 emyl3 merged commit 0819dea into main Apr 16, 2024
6 of 7 checks passed
@emyl3 emyl3 deleted the elisa/6844-upgrade-node branch April 16, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzhao99 fzhao99 fzhao99 approved these changes

@mpbrown mpbrown mpbrown approved these changes

@mehansen mehansen Awaiting requested review from mehansen

@DanielSass DanielSass Awaiting requested review from DanielSass

@alismx alismx Awaiting requested review from alismx

@bobbywells52 bobbywells52 Awaiting requested review from bobbywells52

@shanice-skylight shanice-skylight Awaiting requested review from shanice-skylight

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emyl3 @mpbrown @fzhao99