Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elisa/remove webpack #698

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Elisa/remove webpack #698

merged 2 commits into from
Jun 18, 2024

Conversation

emyl3
Copy link
Collaborator

@emyl3 emyl3 commented Jun 17, 2024 •
edited
Loading

Related Issue or Background Info

Changes Proposed

  • Remove webpack and webpack-cli dependencies

Additional Information

N/A

Screenshots / Demos

  • deployed on dev3

Checklist for Author and Reviewer

Design

  • Any UI/UX changes have a designer as a reviewer, and changes have been approved
  • Any large-scale changes have been deployed to test, dev, or pentest and smoke-tested by both the engineering and design teams

Content

  • Any content changes (including new error messages) have been approved by content team

Support

  • Any changes that might generate new support requests have been flagged to the support team

Testing

  • Includes a summary of what a code reviewer should verify

dependabot bot and others added 2 commits June 17, 2024 06:58
@dependabot
Bump webpack from 5.91.0 to 5.92.0
77e64f7 
Bumps [webpack](https://github.com/webpack/webpack) from 5.91.0 to 5.92.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.91.0...v5.92.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@emyl3
Remove webpack and webpack-cli
17b3cd0
@emyl3 emyl3 force-pushed the elisa/remove-webpack branch from c47d7f6 to 17b3cd0 Compare June 17, 2024 20:40
@emyl3 emyl3 marked this pull request as ready for review June 17, 2024 20:42
@emyl3 emyl3 mentioned this pull request Jun 17, 2024
Closed
mehansen
mehansen approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@mehansen mehansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

bobbywells52
bobbywells52 approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@bobbywells52 bobbywells52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@emyl3 emyl3 merged commit 56c7e46 into main Jun 18, 2024
7 checks passed
@emyl3 emyl3 deleted the elisa/remove-webpack branch June 18, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbywells52 bobbywells52 bobbywells52 approved these changes

@fzhao99 fzhao99 fzhao99 approved these changes

@mpbrown mpbrown mpbrown approved these changes

@mehansen mehansen mehansen approved these changes

@DanielSass DanielSass Awaiting requested review from DanielSass

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emyl3 @mehansen @mpbrown @fzhao99 @bobbywells52