Linting, security scans and docs 🥇 #1
Conversation
… unuses variables, and pinning provider versions
alismx
force-pushed
the
alis/improve_linting
branch
from
1b8942e to
2dff9d4
Compare
alismx
changed the title
_local.tf
Outdated
| registry_username = data.aws_ecr_authorization_token.this.user_name | ||
| registry_password = data.aws_ecr_authorization_token.this.password | ||
| service_data = { | ||
| service_data = var.service_data == {} ? { |
There was a problem hiding this comment.
Small item, non-blocking: would it be more legible for us to use the coalesce function here, so the last part of the ternary isn't dangling off the end of the block a few dozen lines down?
More info here: https://developer.hashicorp.com/terraform/language/functions/coalesce
There was a problem hiding this comment.
Hey! I looked at coalesce, which seems like a good win for readability. 🔺
I also took a peak at merge, I could see using it to allow for more refined control of the service_data object without needing to pass in the entire blob. ( like maybe I just want the orchestration service to have more memory) That said, it will not work for today, so I'll file that away in the maybe someday column.
There was a problem hiding this comment.
After testing coalesce, I got some very weird behavior. The most consistent behavior came from checking the service_data object with this:
length(var.service_data) > 0 ? var.service_data : ...
I'd like to use this version; it's consistent and solves the issue of var.service_data getting lost at the end.
| ecr-viewer = { | ||
| short_name = "ecrv", | ||
| fargate_cpu = 1024, | ||
| fargate_memory = 2048, | ||
| min_capacity = 1 | ||
| max_capacity = 5 | ||
| min_capacity = 1, |
There was a problem hiding this comment.
Oh, no. This is going to be one of these stylistic areas that gives me fits. Is this JSON or YAML here? I've got a similar structure in dibbs-azure for the block definitions that uses no commas whatsoever. I'm in the camp that they clutter things unnecessarily unless they are explicitly needed by the language spec.
DEVOPS PULL REQUEST
Related Issue
Changes Proposed
terraformandawspluginsAdditional Information