-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow SSL cert and port 443 setup 🔒 #9
Conversation
content { | ||
type = "forward" | ||
target_group_arn = each.value.arn | ||
# terraform will complain that we have a redirect action and a forward action but the issue disappears on a subsequent apply |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate on this terraform complaint?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a deprecation warning saying we shouldn't have a redirect action, not anything that throws.
This happens when I create the infra with a cert and then run it without the cert (destroying all the ssl/443/cert related infra). That shouldn't be a typical case.
The resource doesn't explicitly delete the redirect part of the action, but it does implicitly because AWS doesn't allow it, which is why we don't see it on the follow-up run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a possible solution to the trivy issue.
@@ -23,7 +23,7 @@ jobs: | |||
with: | |||
scan-type: 'fs' | |||
scan-ref: . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This scan-ref
block is likely causing the false failures. Normally, we would isolate this to an operations directory, but we don't have that luxury here. Consider implementing skip-dirs
to exclude the .cache
directory: https://trivy.dev/v0.56/docs/configuration/skipping/
DEVOPS PULL REQUEST
Related Issue
Changes Proposed
alb_listener_rules_arns
tohttp_alb_listener_rules_arns
.https_alb_listener_rules_arns
for HTTPS listener rules.certificate_arn
to manage SSL certificate for ALB.aws_alb_listener_rule.this
intoaws_alb_listener_rule.http
andaws_alb_listener_rule.https
.certificate_arn
.aws_alb_listener.https
resource with appropriate SSL settings and default action.forward
andredirect
actions based on the presence ofcertificate_arn
.aws_alb_listener_rule.https
for handling HTTPS paths with SSL termination.