Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WW3 failing restart #160

Merged
merged 2 commits into from
May 7, 2024
Merged

Fix WW3 failing restart #160

merged 2 commits into from
May 7, 2024

Conversation

ezhilsabareesh8
Copy link
Contributor

This PR fixes #97 by adding ice thickness (IC1) and floe diameter (IC5) to the restart write and read routines of WW3.

@anton-seaice
Copy link
Contributor

If the configuration does not need ice thickness or floe diameter, will this change cause those restarts to fail? Or will this be compatible with all wave-ice propagation models in WW3

@micaeljtoliveira
Copy link
Contributor

If the configuration does not need ice thickness or floe diameter, will this change cause those restarts to fail? Or will this be compatible with all wave-ice propagation models in WW3

That's a good question. I think it's better to check this before merging.

@ezhilsabareesh8
Copy link
Contributor Author

ezhilsabareesh8 commented May 7, 2024

If the configuration does not need ice thickness or floe diameter, will this change cause those restarts to fail?

I tested it with a different model which doesn't require these variables and it is working. I think it is because WW3 still write these variables in the restart files but it will be default values.

@ezhilsabareesh8 ezhilsabareesh8 merged commit 5373389 into main May 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing WW3 Restart File Read in WW3
4 participants