-
Notifications
You must be signed in to change notification settings - Fork 14
feat: (WIP) Add insert_link_hugr
to add entrypoint subtree AND link
#2555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: acl/link_hugr
Are you sure you want to change the base?
Conversation
Remove unused fn directive
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## acl/link_hugr #2555 +/- ##
=================================================
- Coverage 83.00% 82.91% -0.10%
=================================================
Files 254 255 +1
Lines 47781 47933 +152
Branches 43292 43444 +152
=================================================
+ Hits 39663 39743 +80
- Misses 6055 6124 +69
- Partials 2063 2066 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary
|
/// If the new function is reachable, then add it (as per [Self::Add]); | ||
/// otherwise, skip it. | ||
AddIfReached, | ||
// /// If the new function is reachable, then add it but make it [Private]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove this, it can follow in another PR
insert_link_hugr
to add entrypoint subtree AND linkinsert_link_hugr
to add entrypoint subtree AND link
Follows #2529
insert_link_hugr
andinsert_link_view
taking a node under which to add the entrypointTODO
parent
is the target'smodule_root
, then basically just forces that function to be a reachable one? Or should we e.g. force adding it even contrary to the signature-conflict/multiple-impl handling used for other functions?)closes #2517