Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp rework #117

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Timestamp rework #117

wants to merge 16 commits into from

Conversation

Hanmac
Copy link
Contributor

@Hanmac Hanmac commented Apr 22, 2022

Draft for now, i need to update more Effects, so that the WrappedAbility Check can be removed

The Main reason for this MR, Split Timestamp into:

  • GameTimestamp that is used by the Rules when an Card becomes an new Object
  • LayerTimestamp that is used when the Rules talk about a Card getting a new timestamp, only used for Static Layer Effects

Also

  • For Player, add a new check "isInGame" which means the Player has neither lost, nor won (in case of Limited Influence)
  • Also More Effects should check for GameTimestamp in Effect so it is checked for Triggered objects
  • canBeTargetedBy doesn't needs to be checked in Effect, this is handled by Magic Stack

@Hanmac Hanmac force-pushed the timestampRework branch 2 times, most recently from d32d34c to f150f13 Compare April 23, 2022 06:07
@tool4ever
Copy link
Contributor

Had the AI play around 50 games on this branch, seems stable so far

If we get the old issues back I think there should be some with timestamp stuff that might get solved

Let me know if I should test for anything else

@Hanmac
Copy link
Contributor Author

Hanmac commented Nov 25, 2022

canBeTargetedBy doesn't needs to be checked in Effect, this is handled by Magic Stack

I need rules check if that is true or not.
It may or may not depends on the lines of code if they are on the same line in the oracle.

@Hanmac
Copy link
Contributor Author

Hanmac commented Jun 18, 2023

probably need to check for cards that got released after i started working on this for their Triggered values

Copy link
Contributor

@tool4ever tool4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That must have been painful to rebase 😓

Still seems stable

@github-actions
Copy link

This PR has not been updated in a while nad has been marked on stale. Stale PRs will be auto closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants