-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timestamp rework #117
base: master
Are you sure you want to change the base?
Timestamp rework #117
Conversation
forge-game/src/main/java/forge/game/ability/effects/DamageEachEffect.java
Outdated
Show resolved
Hide resolved
forge-game/src/main/java/forge/game/ability/effects/CountersMultiplyEffect.java
Show resolved
Hide resolved
d32d34c
to
f150f13
Compare
Had the AI play around 50 games on this branch, seems stable so far If we get the old issues back I think there should be some with timestamp stuff that might get solved Let me know if I should test for anything else |
41c9196
to
b33d0c7
Compare
I need rules check if that is true or not. |
probably need to check for cards that got released after i started working on this for their Triggered values |
…meState and Player for isInGame
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That must have been painful to rebase 😓
Still seems stable
38da1f2
to
369a5d5
Compare
This PR has not been updated in a while nad has been marked on stale. Stale PRs will be auto closed |
3cc5eb4
to
7e62540
Compare
Draft for now, i need to update more Effects, so that the WrappedAbility Check can be removed
The Main reason for this MR, Split Timestamp into:
Also