Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Android build (SDK 34), Java 17 #6103

Open
wants to merge 63 commits into
base: master
Choose a base branch
from
Open

Update Android build (SDK 34), Java 17 #6103

wants to merge 63 commits into from

Conversation

kevlahnota
Copy link
Contributor

@kevlahnota kevlahnota commented Sep 8, 2024 •
edited
Loading

  • Java 17
  • targetSDK 34
  • add modded uber-apk-signer.jar for signing cert
  • add standalone proguard 7.5.0
  • update some dependency

@tehdiplomat
Copy link
Contributor

tehdiplomat commented Sep 8, 2024 •
edited
Loading

Awesome!

Some thoughts:

  • We should bump the versions up to 2.0.0 and announce that we're no longer going to be supporting Java 8 at the same time we merge this PR.
  • It might be nice to do one more full release that supports 1.8 before this gets merged.

@Hanmac
Copy link
Contributor

Hanmac commented Sep 8, 2024

@kevlahnota would be nice if we could implement #4977 in this update

@kevlahnota
Copy link
Contributor Author

@kevlahnota would be nice if we could implement #4977 in this update

Just push a new release / update the plugin https://github.com/Card-Forge/android-maven-plugin
it should work since the PR is merged.

@kevlahnota kevlahnota changed the title update android builds to SDK 29, use Java 11 update android builds to SDK 33, use Java 11 Sep 9, 2024
@kevlahnota kevlahnota closed this Sep 9, 2024
@kevlahnota kevlahnota reopened this Sep 9, 2024
@kevlahnota kevlahnota marked this pull request as draft September 9, 2024 07:53
@Hanmac Hanmac mentioned this pull request Sep 9, 2024
Merged
@Hanmac
Copy link
Contributor

Hanmac commented Sep 9, 2024 •
edited
Loading

@kevlahnota for Signing, checkout ~~ https://github.com/MuntashirAkon/apksig-android ~~

Better: https://github.com/jenkinsci/android-signing-plugin

@kevlahnota kevlahnota changed the title update android builds to SDK 33, use Java 11 update android builds to SDK 29, use Java 11 Sep 9, 2024
@kevlahnota
Copy link
Contributor Author

@kevlahnota for Signing, checkout ~~ https://github.com/MuntashirAkon/apksig-android ~~

Better: https://github.com/jenkinsci/android-signing-plugin

Reverted to sdk 29, seems target sdk 33 and above somehow don't allow installation without proper signature/signing on latest android version (tested with android 14)

@kevlahnota kevlahnota marked this pull request as ready for review September 10, 2024 10:01
@kevlahnota kevlahnota mentioned this pull request Sep 11, 2024
Closed
@kevlahnota kevlahnota changed the title Update Android build Update Android build (SDK 34), Java 17 Sep 26, 2024
@kevlahnota kevlahnota added Desktop dependencies Pull requests that update a dependency file labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tehdiplomat tehdiplomat tehdiplomat left review comments

@Jetz72 Jetz72 Jetz72 left review comments

@Hanmac Hanmac Awaiting requested review from Hanmac

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Android dependencies Pull requests that update a dependency file Desktop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevlahnota @tehdiplomat @Hanmac @Jetz72