-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Android build (SDK 34), Java 17 #6103
Open
kevlahnota
wants to merge
63
commits into
Card-Forge:master
Choose a base branch
from
kevlahnota:master2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+529
−546
Open
Changes from 36 commits
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
09b5ee8
update android builds to SDK 29, use Java 11
kevlahnota 3e5b239
Merge branch 'master' into master2
kevlahnota a8f6842
update some dependency
kevlahnota af89e52
update target sdk and build tools to 33
kevlahnota 21b6e15
update
kevlahnota 7ea3e6b
Merge branch 'master' into master2
kevlahnota c40edf8
revert to sdk 29 (Android 10) until the v2 signing works on android 1…
kevlahnota b790455
Merge branch 'master' into master2
kevlahnota 822676d
Merge branch 'master' into master2
kevlahnota bfca199
Merge branch 'master' into master2
kevlahnota e623e02
update network check
kevlahnota d7c106b
Merge branch 'master' into master2
kevlahnota 78f3d3d
update more dependency
kevlahnota d6b9ad5
Merge branch 'master' into master2
kevlahnota b683f2d
Merge branch 'master' into master2
kevlahnota 83b653a
Merge branch 'master' into master2
kevlahnota f442189
update SplashScreen
kevlahnota b9a36bd
Merge branch 'master' into master2
kevlahnota 368ef9d
Merge branch 'master' into master2
kevlahnota 1918770
update to sdk 33, update v2 signer-modded
kevlahnota ca9f2da
update manifest, add uber-apk-signer
kevlahnota edc3af5
Merge branch 'master' into master2
kevlahnota 74eebf4
move signer to tools
kevlahnota b6a0540
Merge branch 'master' into master2
kevlahnota 372c3cf
Merge branch 'master' into master2
kevlahnota dd11d04
Merge branch 'master' into master2
kevlahnota 99c235e
Merge branch 'master' into master2
kevlahnota ef6716c
update exec-plugin
kevlahnota 116720a
update compiler release
kevlahnota 9fc9384
Merge branch 'master' into master2
kevlahnota c04055f
Merge branch 'master' into master2
kevlahnota 2154066
Merge branch 'master' into master2
kevlahnota 0c248d7
Merge branch 'master' into master2
kevlahnota de9823a
Merge branch 'master' into master2
kevlahnota bbc3d56
update maven, dependency plugins
kevlahnota 5099d0f
set landscape sensor from android 11 onwards
kevlahnota fd7da13
Merge branch 'master' into master2
kevlahnota 0dde987
update jaxb-api -> fix illegal access warning
kevlahnota fd4ba13
Merge branch 'master' into master2
kevlahnota f53bc65
Merge branch 'master' into master2
kevlahnota 25435c8
update sign tool
kevlahnota c1f9c76
Merge branch 'master' into master2
kevlahnota ca2110c
Merge branch 'master' into master2
kevlahnota 34c6258
update maven
kevlahnota bd8ff97
Merge branch 'master' into master2
kevlahnota c6d334a
update
kevlahnota 7725d9e
Merge branch 'master' into master2
kevlahnota 3577f57
Merge branch 'master' into master2
kevlahnota 56400d4
JAVA17 Update
kevlahnota c07e3b9
update argsfor Java 17
kevlahnota a7c69da
fix tests
kevlahnota 67cbd14
update info
kevlahnota f5949b9
Merge branch 'master' into master2
kevlahnota 3a41f9d
update more dependency, update CardMockTestCase
kevlahnota 352967c
update proguard, fix expected stack map table for method with non-lin…
kevlahnota 83e28d6
update android pom, proguard
kevlahnota 1f6f14c
remove unused property
kevlahnota 7594888
SKIN Update
kevlahnota ddf009f
update skinlist
kevlahnota ea9aab7
mobile -> enable combat arrows on 2 player
kevlahnota 683f9c2
Merge branch 'master' into master2
kevlahnota f9fc5b4
fix some icon colors
kevlahnota 61bf589
Merge branch 'master' into master2
kevlahnota File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signing isn't needed anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's included on the android pom file, it will sign with v2, v3 on install phase using the modded signer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are those keystore passwords just placeholders for testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check publish.bat in android module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Knowing that the keystore credentials have already been in a publicly visible file for the last 9 years isn't doing much to mitigate my concern... Someone would still need the keystore itself to do anything malicious but if those are the actual passwords then that's a layer of security that isn't doing anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the github actions template works on the pom file, feel free to update it since I don't know how those variable interact from github to maven via pom file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll admit I don't know much about that either, and the credentials would need to be changed by someone with more access than me anyway. I could open an issue for it but I'm hesitant to give security problems more visibility than necessary. It's probably not a huge problem in the short term though.