Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to messages and re-run notebooks #83

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Conversation

mirams
Copy link
Member

@mirams mirams commented Oct 9, 2024

  1. Fix heighest -> highest
  2. Fix some 'ordinals' ('st','nd','rd','th') with a fairly random bit of code I got off stackoverflow, but seems to work!
  3. Re-run notebooks

@EricWay1024
Copy link
Collaborator

EricWay1024 commented Oct 9, 2024

I ran black on the codebase to make the style check green; in particular it changed almost all single quotes to double, except those that have double quotes in the string.

@EricWay1024
Copy link
Collaborator

  1. Fix some 'ordinals' ('st','nd','rd','th') with a fairly random bit of code I got off stackoverflow, but seems to work!

I looked at the code and can confirm it is a valid algorithm

@EricWay1024 EricWay1024 merged commit dbea5b5 into main Oct 9, 2024
3 checks passed
@EricWay1024 EricWay1024 deleted the tweaks_to_message branch October 9, 2024 15:25
@MichaelClerx
Copy link
Member

Bit overkill Eric!
Only a very small fraction of the changes that tool made were necessary. Especially the consistent use of ' instead of " is a conscious way of reducing RSI 😁

@MichaelClerx
Copy link
Member

Also makes it impossible to see what was actually changed in this PR.

@MichaelClerx
Copy link
Member

MichaelClerx commented Oct 9, 2024

In general, good not to make any changes when you're reviewing too (because then those changes have not been reviewed!)

(Making suggestions, however, is strongly encouranged!)

@MichaelClerx
Copy link
Member

I'll re-open and revert some changes 😄

@MichaelClerx MichaelClerx restored the tweaks_to_message branch October 9, 2024 16:21
@MichaelClerx MichaelClerx mentioned this pull request Oct 9, 2024
@EricWay1024
Copy link
Collaborator

Sorry I was too hasty in changing everything; thanks for the fixing! Will be careful next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants