-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweaks to messages and re-run notebooks #83
Conversation
mirams
commented
Oct 9, 2024
- Fix heighest -> highest
- Fix some 'ordinals' ('st','nd','rd','th') with a fairly random bit of code I got off stackoverflow, but seems to work!
- Re-run notebooks
I ran |
I looked at the code and can confirm it is a valid algorithm |
Bit overkill Eric! |
Also makes it impossible to see what was actually changed in this PR. |
In general, good not to make any changes when you're reviewing too (because then those changes have not been reviewed!) (Making suggestions, however, is strongly encouranged!) |
I'll re-open and revert some changes 😄 |
Sorry I was too hasty in changing everything; thanks for the fixing! Will be careful next time |