Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ap-nimbus-app-manager Release 2.0.0 #10

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

kwabenantim
Copy link
Member

@kwabenantim kwabenantim added the enhancement New feature or request label Jun 26, 2024
@kwabenantim kwabenantim self-assigned this Jun 26, 2024
@kwabenantim kwabenantim linked an issue Jun 26, 2024 that may be closed by this pull request
17 tasks
@kwabenantim
Copy link
Member Author

kwabenantim commented Jun 27, 2024

The current "Active LTS" is now Node 20, and Node 18 is currently in "Maintenance" mode. It is probably a good time to upgrade.

@kwabenantim
Copy link
Member Author

kwabenantim commented Jun 30, 2024

The ip package no longer seems to be in active development.

# npm audit report

ip  *
Severity: high
ip SSRF improper categorization in isPublic - https://github.com/advisories/GHSA-2p57-rm9w-gvfp
No fix available
node_modules/ip

1 high severity vulnerability

Some issues need review, and may require choosing
a different dependency.

@kwabenantim
Copy link
Member Author

kwabenantim commented Jul 10, 2024

The ip github repository has recently been unarchived again. However, the dependabot alert remains.

Currently, app-manager only needs ip to retrieve an address:

const ip = require('ip');

return_obj = {
  'success': {
    'id': simulation_id,
    'ip': ip.address()
  }
};

This could be replaced with a manual function like:

const os = require('os');

function ip_address() {
  const interfaces = os.networkInterfaces();

  for (const networks of Object.values(interfaces)) {
    for (const network of networks) {
      if (network.family == 'IPv4' && !network.internal) {
        return network.address;
      }
    }
  }

  return '127.0.0.1';
}

return_obj = {
  'success': {
    'id': simulation_id,
    'ip': ip_address()
  }
};

@mirams
Copy link
Member

mirams commented Aug 6, 2024

All OK by me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release Ap-Nimbus v2.0.0
2 participants