Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ldap authentication + docker compose example + sqlite option #133

Closed
wants to merge 14 commits into from

Conversation

martinjrobins
Copy link
Collaborator

Fixes #132

This adds an option to authenticate via a ldap server, with logging in users as either normal users or admin depending on the ldap groups they are assigned to. This feature is controlled by a number of environment variables, which I've added to the example env file with some comments

It also adds some other quality-of-life stuff that I found useful, let me know if this is what you want:

  • the develop settings include an option to use an sqlite database rather than postgres (I found this useful for developing outside a docker container)
  • the develop settings add some debug logging
  • the develop settings use python dotenv to load up a .env file if it exists (again I found this useful for developing outside a docker container)
  • I've added docker-compose.yaml file for easy deployment of the client-direct app
  • I've edited the Dockerfile to copy the current context dir rather than cloning from the master branch of the repo. This allows you to deploy from a custom branch or commit.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 52.17391% with 33 lines in your changes missing coverage. Please review.

Project coverage is 97.60%. Comparing base (c95d6ed) to head (2cd8d34).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
client/config/production_settings.py 54.71% 23 Missing and 1 partial ⚠️
client/config/develop_settings.py 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
- Coverage   99.60%   97.60%   -2.00%     
==========================================
  Files          30       30              
  Lines        1503     1543      +40     
  Branches      244      252       +8     
==========================================
+ Hits         1497     1506       +9     
- Misses          6       36      +30     
- Partials        0        1       +1     
Flag Coverage Δ
97.60% <52.17%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirams
Copy link
Member

mirams commented Sep 25, 2024

Did you mean to close it @martinjrobins ?

@martinjrobins
Copy link
Collaborator Author

yea, once @kwabenantim gave me permissions I created a local branch with a copy of this PR #134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LDAP authentication option
2 participants