Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing for subtraction plot function #12

Closed
wants to merge 14 commits into from

Conversation

joeyshuttleworth
Copy link
Collaborator

Description

Fixes #11 by including a unit test that checks that do_subtraction_plot runs without errors. Change the parameters of do_subtraction_plot so that testing is easier.

Additionally, add a line to run run_herg_qc.py in the testing workflow

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

Documentation checklist

  • I have updated all documentation in the code where necessary.
  • I have checked spelling in all (new) comments and documentation.
  • I have added a note to RELEASE.md if relevant (new feature, breaking change, or notable bug fix).

@joeyshuttleworth
Copy link
Collaborator Author

Merged into #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subtraction plot functionality is not currently tested
1 participant