Apply QC to leak-corrected traces. Fix subtraction plots. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyshuttleworth
commented
Aug 8, 2024
mirams
reviewed
Aug 8, 2024
| @@ -914,12 +910,6 @@ def run_qc_for_protocol(readname, savename, time_strs, args): | |||
| before_currents[sweep, :] = before_raw | |||
| after_currents[sweep, :] = after_raw | |||
|
|
|||
| R_leftover = np.full(before_currents.shape[0], np.nan) | |||
There was a problem hiding this comment.
This looks important, was it duplicated somewhere else?
There was a problem hiding this comment.
Yes, it was originally (and still is) in `extract_protocol', meaning we get an R_leftover value for every single protocol in the dataset and not just the staircase protocol.
mirams
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #11
Apply the hERG QC to leak-corrected traces instead of raw traces (as in 10.1016/j.bpj.2019.07.029)
Additionally, fix subtraction plots which had incorrect leak-subtraction. Modify the notation in the subtraction plots so that it matches our in-progress publications.
Types of changes
Testing
Documentation checklist