Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hilary dev #53

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Hilary dev #53

wants to merge 10 commits into from

Conversation

hilaryh
Copy link
Contributor

@hilaryh hilaryh commented Dec 11, 2024

Description

  • Updated subtraction_plots.py to make plots easier to read
  • Edited run_herg_qc to allow for less specific export_config.py protocol dict

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

Documentation checklist

  • I have updated all documentation in the code where necessary.
  • I have checked spelling in all (new) comments and documentation.
  • I have added a note to RELEASE.md if relevant (new feature, breaking change, or notable bug fix).

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 34.32836% with 88 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@f5e5052). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pcpostprocess/subtraction_plots.py 34.32% 88 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage        ?   78.79%           
=======================================
  Files           ?        7           
  Lines           ?      646           
  Branches        ?        0           
=======================================
  Hits            ?      509           
  Misses          ?      137           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant