Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaks to tests #54

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Tweaks to tests #54

merged 2 commits into from
Jan 17, 2025

Conversation

MichaelClerx
Copy link
Member

@MichaelClerx MichaelClerx commented Jan 7, 2025 •
edited
Loading

  • excluding test data from flake8
  • excluding test output from git
  • stopped tests returning values (deprecated)
  • dropped 3.7 testing, added 3.13

@kwabenantim kwabenantim self-requested a review January 17, 2025 11:40
kwabenantim
kwabenantim approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@kwabenantim kwabenantim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Dropping testing for Python 3.7 should also stop the CI from falling over

@mirams mirams merged commit e2685b5 into main Jan 17, 2025
7 checks passed
@mirams mirams deleted the test-tweaks branch January 17, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwabenantim kwabenantim kwabenantim approved these changes

@joeyshuttleworth joeyshuttleworth Awaiting requested review from joeyshuttleworth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelClerx @kwabenantim @mirams