Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove (AssaySupport) legacy functions and add more tests #6

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

remove (AssaySupport) legacy functions and add more tests #6

wants to merge 18 commits into from

Commits on Sep 4, 2024

  1. remove dependancy on peaks2df (legacy), swich to use MALDIquant::matc… 

    …h.clostes() directly
    @thomas-enzlein
    thomas-enzlein committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    3127218 View commit details
    Browse the repository at this point in the history

  2. - remove rhistory 

    - remove peaks2df()
    @thomas-enzlein
    thomas-enzlein committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    da9c551 View commit details
    Browse the repository at this point in the history

  3. merge main into dev 

    Merge branch 'main' into dev

# Conflicts:
#	.Rhistory
#	R/helpers.R
    @thomas-enzlein
    thomas-enzlein committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    588ecb8 View commit details
    Browse the repository at this point in the history

  4. - add test for shiftMassAxis()

    @thomas-enzlein
    thomas-enzlein committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    40dcdce View commit details
    Browse the repository at this point in the history

  5. - remove not used allowNoMatch argument in getMzShift() 

    - more tests for getMzShift()
    @thomas-enzlein
    thomas-enzlein committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    81a6a11 View commit details
    Browse the repository at this point in the history

  6. - add test to .aggregateSpectra() 

    - remove un-used argument from quality metrics
    @thomas-enzlein
    thomas-enzlein committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    5ab650a View commit details
    Browse the repository at this point in the history

  7. - add test for getNormFactors()

    @thomas-enzlein
    thomas-enzlein committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    7cd3390 View commit details
    Browse the repository at this point in the history

  8. - add some more test cases to extractSpots(), getNormFactors() and sh… 

    …iftMassAxis()
    @thomas-enzlein
    thomas-enzlein committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    0c58115 View commit details
    Browse the repository at this point in the history

  9. - add test to normalize() 

    - remove redundant function .scalingFactor()
    @thomas-enzlein
    thomas-enzlein committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    ba0554d View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. - small correction for getRecalibrationError(): set verbose to FALSE

    @thomas-enzlein
    thomas-enzlein committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    366d5e7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' of https://github.com/CeMOS-Mannheim/MALDIcellassay … 

    …into dev
    @thomas-enzlein
    thomas-enzlein committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    f39ad90 View commit details
    Browse the repository at this point in the history

  3. - set validation method for MALDIassay class 

    - include tests for MALDIassay class
    @thomas-enzlein
    thomas-enzlein committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    5554dff View commit details
    Browse the repository at this point in the history

  4. - test validObject() and show() method of MALDIassay explicitly

    @thomas-enzlein
    thomas-enzlein committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    3a971e4 View commit details
    Browse the repository at this point in the history

  5. - call validation method for MALDIassay directly in tests (for coverage)

    @thomas-enzlein
    thomas-enzlein committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    24a16da View commit details
    Browse the repository at this point in the history

  6. - tests for all validity checks of MALDIassay-class

    @thomas-enzlein
    thomas-enzlein committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    0eeafd7 View commit details
    Browse the repository at this point in the history

  7. - more tests for normalize

    @thomas-enzlein
    thomas-enzlein committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    9084ea4 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. - add allowNoMatch argument to getMzShift()

    @thomas-enzlein
    thomas-enzlein committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    f95b5a3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' of https://github.com/CeMOS-Mannheim/MALDIcellassay … 

    …into dev
    @thomas-enzlein
    thomas-enzlein committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    7ddccf7 View commit details
    Browse the repository at this point in the history