Run tests in CI, and fail CI if tests fail#10
Open
Leseratte10 wants to merge 1 commit intoChadderz121:masterfrom
Leseratte10:ci_tests
Open
Run tests in CI, and fail CI if tests fail#10Leseratte10 wants to merge 1 commit intoChadderz121:masterfrom Leseratte10:ci_tests
Leseratte10 wants to merge 1 commit intoChadderz121:masterfrom
Leseratte10:ci_tests
Conversation
Chadderz121
reviewed
Nov 22, 2020
| # Tests | ||
| TEST := | ||
|
|
||
| MAKEFLAGS += k |
Owner
There was a problem hiding this comment.
Would it make more sense to call make -k rather than trying to edit the arguments from within the makefile?
Contributor
Author
There was a problem hiding this comment.
For the CI itself, maybe. But that parameter makes sense when manually called from the console as well, right? With the other change, the tests would stop after the first error which is probably not what you want by default, so setting the flag inside the Makefile seemed more useful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the CI and all the test stuff is merged, here's another update for that:
With this change to the CI pipeline, all the tests will also run for each commit, and the CI build will fail if any of the tests fail.
The
MAKEFLAGS += kmakes sure that the tests continue even if one of them fails (so everything gets tested), and thefalseafter a failed test is needed so the final return value of make returns an error so the CI build stops.