Skip to content

Run tests in CI, and fail CI if tests fail #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Leseratte10 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Run tests in CI, and fail CI if tests fail #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,12 @@ jobs:
tar -xf cache/gamecube-tools-1.0.2-1-linux.pkg.tar.xz opt/devkitpro/tools/bin/elf2dol --strip-components=4
sudo cp elf2dol /usr/local/bin/elf2dol
tar -xf cache/ppc-mxml-2.11-2-any.pkg.tar.xz opt/devkitpro/portlibs --strip-components=1

- name: Run tests
run: |
cd test
sudo apt install libmxml-dev
make

- name: Compile
run: |
Expand Down
4 changes: 3 additions & 1 deletion test/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ LIB_DIRS :=
# Tests
TEST :=

MAKEFLAGS += k
Copy link
Owner

@Chadderz121 Chadderz121 Nov 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make more sense to call make -k rather than trying to edit the arguments from within the makefile?

Copy link
Contributor Author

@Leseratte10 Leseratte10 Nov 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the CI itself, maybe. But that parameter makes sense when manually called from the console as well, right? With the other change, the tests would stop after the first error which is probably not what you want by default, so setting the flag inside the Makefile seemed more useful.


###############################################################################
# Rule to make everything.
PHONY += all
Expand Down Expand Up @@ -85,7 +87,7 @@ PHONY += regression
regression : $(addprefix test_, $(TEST))

test_% : $(TARGET)
$Q{ $(TARGET) $* && echo "Test $* passed"; } || echo "Test $* failed ($$?)"
$Q{ $(TARGET) $* && echo "Test $* passed"; } || { echo "Test $* failed ($$?)"; false; }

###############################################################################
# Special build rules
Expand Down