Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit sccache caches and improve PCH #4727

Merged
merged 8 commits into from
Jul 19, 2023
Merged

Limit sccache caches and improve PCH #4727

merged 8 commits into from
Jul 19, 2023

Conversation

Nerixyz
Copy link
Contributor

@Nerixyz Nerixyz commented Jul 19, 2023

Description

  • Limits creation of caches created by sccache to the default branch only. PRs should use that cache when running their builds.
  • Add signals2 (used in various places) and circular_buffer (used in LimitedQueue) to PCH (found through vcperf)
  • Remove duplicate includes from PCH (ones with QtWidgets/... or QtCore/...)
  • Remove barely used includes (found through grepping for them)

This should hopefully speed up builds a bit.

pajlada
pajlada requested changes Jul 19, 2023
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
@pajlada pajlada enabled auto-merge (squash) July 19, 2023 19:50
@pajlada pajlada merged commit 7fd01ac into Chatterino:master Jul 19, 2023
15 of 17 checks passed
@Nerixyz Nerixyz deleted the perf/win branch July 20, 2023 07:08
@ilya-zlobintsev ilya-zlobintsev mentioned this pull request Jan 30, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pajlada pajlada pajlada approved these changes

Assignees
No one assigned
Labels
no changelog entry needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nerixyz @pajlada