Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit sccache caches and improve PCH #4727

Merged
merged 8 commits into from
Jul 19, 2023
Merged

Limit sccache caches and improve PCH #4727

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fc8e1fa
ci: only save sccache on master
Nerixyz Jul 19, 2023
3a30d67
build: add signals2 to PCH
Nerixyz Jul 19, 2023
9a28366
build: add circular_buffer to PCH
Nerixyz Jul 19, 2023
ac531cf
build: remove duplicate includes from PCH
Nerixyz Jul 19, 2023
c008618
fix: remove rarely used includes
Nerixyz Jul 19, 2023
0f0ec40
ci: enable pch on some windows jobs
Nerixyz Jul 19, 2023
c0a24cf
fix: remove matrix opt and check in env block
Nerixyz Jul 19, 2023
577970b
fix: clarify Windows
Nerixyz Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ jobs:
plugins: [false]
skip-artifact: [false]
skip-crashpad: [false]
skip-pch: [false]
pajlada marked this conversation as resolved.
Show resolved Hide resolved
clang-tidy-review: [false]
include:
# Ubuntu 20.04, Qt 5.12
Expand All @@ -41,6 +42,7 @@ jobs:
plugins: false
skip-artifact: false
skip-crashpad: false
skip-pch: true
clang-tidy-review: false
# Ubuntu 22.04, Qt 5.15
- os: ubuntu-22.04
Expand All @@ -49,6 +51,7 @@ jobs:
plugins: false
skip-artifact: false
skip-crashpad: false
skip-pch: true
clang-tidy-review: true
# Ubuntu 22.04, Qt 6.2.4 - tests LTO & plugins
- os: ubuntu-22.04
Expand All @@ -57,6 +60,7 @@ jobs:
plugins: true
skip-artifact: false
skip-crashpad: false
skip-pch: true
clang-tidy-review: false
# Test for disabling crashpad on Windows
- os: windows-latest
Expand All @@ -65,6 +69,7 @@ jobs:
plugins: false
skip-artifact: true
skip-crashpad: true
skip-pch: true
clang-tidy-review: false

fail-fast: false
Expand Down Expand Up @@ -183,13 +188,15 @@ jobs:
- name: Build (Windows)
if: startsWith(matrix.os, 'windows')
shell: pwsh
env:
C2_USE_PCH: ${{ matrix.skip-pch && 'OFF' || 'ON' }}
run: |
cd build
cmake `
-G"NMake Makefiles" `
-DCMAKE_BUILD_TYPE=RelWithDebInfo `
-DCMAKE_TOOLCHAIN_FILE="conan_toolchain.cmake" `
-DUSE_PRECOMPILED_HEADERS=OFF `
-DUSE_PRECOMPILED_HEADERS=${{ env.C2_USE_PCH }} `
-DBUILD_WITH_CRASHPAD="$Env:C2_ENABLE_CRASHPAD" `
-DCHATTERINO_LTO="$Env:C2_ENABLE_LTO" `
-DCHATTERINO_PLUGINS="$Env:C2_PLUGINS" `
Expand Down
Loading