tc_build: llvm: Fix distribution_components with disabled projects #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to use '--projects' to build certain combinations of subprojects, such as just 'llvm' or 'clang' to build just LLVM or LLVM and clang respectively. When either the 'clang' or 'lld' subproject is not enabled, there is an error when running cmake due to their targets being present in the distributions components list. Only add them to distribution_components if the projects that contain them are enabled. Signed-off-by: Nathan Chancellor <[email protected]>
nathanchance
requested review from
msfjarvis,
nickdesaulniers and
stephenhines
as code owners
msfjarvis
approved these changes
Oct 23, 2023
…UILD_TOOLS=ON With LLVM_BUILD_TOOLS=OFF, these will not be available for build in "all". Signed-off-by: Nathan Chancellor <[email protected]>
I think |
msfjarvis
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to use
--projectsto build certain combinations of subprojects, such as justllvmorclangto build just LLVM or LLVM and clang respectively. When either theclangorlldsubproject is not enabled, there is an error when runningcmakedue to their targets being present in the distributions components list.Only add them to
distribution_componentsif the projects that contain them are enabled.