Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tc_build: llvm: Fix distribution_components with disabled projects #246

Merged
merged 2 commits into from
Oct 23, 2023
Merged

tc_build: llvm: Fix distribution_components with disabled projects #246

merged 2 commits into from
Oct 23, 2023

Commits on Oct 23, 2023

  1. tc_build: llvm: Fix distribution_components with disabled projects 

    It is possible to use '--projects' to build certain combinations of
subprojects, such as just 'llvm' or 'clang' to build just LLVM or LLVM
and clang respectively. When either the 'clang' or 'lld' subproject is
not enabled, there is an error when running cmake due to their targets
being present in the distributions components list.

Only add them to distribution_components if the projects that contain
them are enabled.

Signed-off-by: Nathan Chancellor <[email protected]>
    @nathanchance
    nathanchance committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    e9a493d View commit details
    Browse the repository at this point in the history

  2. tc_build: llvm: Only add tools to distribution_components with LLVM_B… 

    …UILD_TOOLS=ON

With LLVM_BUILD_TOOLS=OFF, these will not be available for build in "all".

Signed-off-by: Nathan Chancellor <[email protected]>
    @nathanchance
    nathanchance committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    e916997 View commit details
    Browse the repository at this point in the history