Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tc_build: llvm: Move use of build_targets out of ninja_cmd #251

Merged
merged 1 commit into from
Nov 8, 2023
Merged

tc_build: llvm: Move use of build_targets out of ninja_cmd #251

merged 1 commit into from
Nov 8, 2023

Commits on Nov 8, 2023

  1. tc_build: llvm: Move use of build_targets out of ninja_cmd 

    Otherwise, they will get added to each invocation of ninja. build_target
should have been added to just the 'self.run_cmd(ninja_cmd)'. While this
does not (currently) cause any problems, it is unnecessary to specify
the base build targets on each subsequent invocation of ninja because
they will have already been built.

To make it clearer for the future, rename ninja_cmd to base_ninja_cmd.

Signed-off-by: Nathan Chancellor <[email protected]>
    @nathanchance
    nathanchance committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    c6765eb View commit details
    Browse the repository at this point in the history