tc_build: llvm: Move use of build_targets out of ninja_cmd #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, they will get added to each invocation of ninja. build_target should have been added to just the 'self.run_cmd(ninja_cmd)'. While this does not (currently) cause any problems, it is unnecessary to specify the base build targets on each subsequent invocation of ninja because they will have already been built. To make it clearer for the future, rename ninja_cmd to base_ninja_cmd. Signed-off-by: Nathan Chancellor <[email protected]>
nathanchance
requested review from
msfjarvis,
nickdesaulniers and
stephenhines
as code owners
msfjarvis
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, they will get added to each invocation of
ninja.build_targetshould have been added to just theself.run_cmd(ninja_cmd). While this does not (currently) cause any problems, it is unnecessary to specify the base build targets on each subsequent invocation ofninjabecause they will have already been built.To make it clearer for the future, rename
ninja_cmdtobase_ninja_cmd.