fix: make gene selector ordering deterministic - #26
Open
Gavriel-lab wants to merge 1 commit into
Open
Conversation
This was referenced May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the existing
pkg/geneselector ordering failure that currently prevents the full PicClaw test suite from passing onmain.ScoreGenecaps scores at1.0, so two strong candidates can tie after scoring.SelectGenespreviously sorted only by score, which left tied candidates in input order. That madeTestSelectGenes_SortedByScorereturn the lower-confidence gene first when both candidates reached the score cap.This PR keeps score as the primary ordering signal, then uses confidence and verification count as deterministic tie-breakers.
Validation
I kept this intentionally small so it can unblock baseline validation without pulling in unrelated edge API changes.