Improvements to make the sass file BS4 compatible. #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the SASS file so that it can be used better with BS4 by aligning to BS4 breakpoints and using the BS4 variables for the colors (keeping the colors consistent and making it easier to change the branding to match the BS4 branding colors). This change will still work if the BS4 source is not included by having all the required variables and mixins right in this source file, however, if a dev has the BS4 source, uncomment the import statements and the BS4 source will override the values defined in this file. Changes to this file also were done to use a 'mobile-first' approach of BS4. Therefore some of the breakpoints might not look exactly as they did before this change, but I did some quick testing at smaller screen sizes and it looked ok. There are also some things that were not tested such as the 'close button' and other options that should be double checked before this is used in the main branch.
precisioninfinity
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to make changes so that the css will be compatible with BS4 SASS source to match BS4 branding colors, yet still work independently if BS4 is not used. This change also improves breakpoints to align with bootstrap 4 breakpoints. All required mixins and variables are copied into this file so it can be used independent of BS4. However, if a user has BS4 source, they can uncomment the import statements and the BS4 source will automatically take precedence over the local variables and mixins.
These upgrades might change the look of really small screens slightly from how it was before but I did some quick testing and it looked ok. There are some things that were not tested such as the 'close button' and the other options like it should be double checked before this is used in the main branch.
No updates were made to the LESS file, so that file may interfere depending on how the build is currently setup.