Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to make the sass file BS4 compatible. #583

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improvements to make the sass file BS4 compatible. #583

wants to merge 1 commit into from

Commits on Jul 26, 2018

  1. Improvements to make sass BS4 compatible. 

    This change updates the SASS file so that it can be used better with BS4 by aligning to BS4 breakpoints and using the BS4 variables for the colors (keeping the colors consistent and making it easier to change the branding to match the BS4 branding colors).  This change will still work if the BS4 source is not included by having all the required variables and mixins right in this source file, however, if a dev has the BS4 source, uncomment the import statements and the BS4 source will override the values defined in this file.

Changes to this file also were done to use a 'mobile-first' approach of BS4.  Therefore some of the breakpoints might not look exactly as they did before this change, but I did some quick testing at smaller screen sizes and it looked ok.  There are also some things that were not tested such as the 'close button' and other options that should be double checked before this is used in the main branch.
    @precisioninfinity
    precisioninfinity committed Jul 26, 2018
    Configuration menu
    Copy the full SHA
    b7d9400 View commit details
    Browse the repository at this point in the history