Skip to content

West Midlands | SDC-July | Gabriel Deng | Sprint 1 | Individual Shell Tools && Number Systems. #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gai93003 wants to merge 8 commits into
base: main
Choose a base branch
from
Open

West Midlands | SDC-July | Gabriel Deng | Sprint 1 | Individual Shell Tools && Number Systems. #84

gai93003 wants to merge 8 commits into from

Conversation

@gai93003
Copy link

@gai93003 gai93003 commented Jul 15, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@gai93003 gai93003 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 15, 2025
@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 31, 2025
LonMcGregor
LonMcGregor reviewed Jul 31, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this task. No issues with your jq and numbers solutions. I have left some comments on your shell tools tasks

@gai93003 gai93003 added the Complete Volunteer to add when work is complete and all review comments have been addressed. label Jan 12, 2026
@github-actions
Copy link

github-actions bot commented Jan 12, 2026

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gai93003 @LonMcGregor