backport: fix(android): Use uno command for all clipboard #10133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minion3665
force-pushed
the
private/skyler/push-qkxxksuysxpw
branch
2 times, most recently
from
7d87cdd
to
d72b27e
Compare
|
I've rebased this back before the slideshow stuff, as that's causing CI to fail. The real solution is figuring out why CI is pulling an old core version |
Minion3665
force-pushed
the
private/skyler/push-qkxxksuysxpw
branch
from
d72b27e
to
3e34215
Compare
Previously on mobile, we were only using the uno commands for some clipboard operations - the pasting ones. That's incorrect, as on Android and iOS we don't have access to the browser clipboard APIs and should be using the native bits, which for Android intercept these UNO calls and use them to manage the clipboard. For iOS, this still falls over - albeit in a slighly different way - but the iOS clipboard code is in core and is nontrivial to fix. I have a patch in the works which would make an API similar to navigator.clipboard for iOS/Android (hopefully reducing our pains here) but I don't see a point in not making a tiny, temporary Android fix. When I change the clipboard system's mobile app bits, this will go away anyway :) Signed-off-by: Skyler Grey <[email protected]> Change-Id: Ifa68b6e956cd5ca75dc8f54b4198a441b2bf1887
Minion3665
force-pushed
the
private/skyler/push-qkxxksuysxpw
branch
from
3e34215
to
b5d7238
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a trivial backport of #10111
Previously on mobile, we were only using the uno commands for some clipboard operations - the pasting ones. That's incorrect, as on Android and iOS we don't have access to the browser clipboard APIs and should be using the native bits, which for Android intercept these UNO calls and use them to manage the clipboard.
For iOS, this still falls over - albeit in a slighly different way - but the iOS clipboard code is in core and is nontrivial to fix. I have a patch in the works which would make an API similar to navigator.clipboard for iOS/Android (hopefully reducing our pains here) but I don't see a point in not making a tiny, temporary Android fix.
When I change the clipboard system's mobile app bits, this will go away anyway :)
Change-Id: Ifa68b6e956cd5ca75dc8f54b4198a441b2bf1887
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay