Added missing buttons for consistency #10136
Open
+33
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Rash419
commented
Sep 26, 2024
•
Rash419
commented
- Target version: master
Signed-off-by: Rashesh <[email protected]> Change-Id: Ic3d2a845dcbee71fde352f1573c71a240058913d
Signed-off-by: Rashesh <[email protected]> Change-Id: I9329583bb2e90f98df4592983635e10c46cb1999
eszkadev
reviewed
Sep 27, 2024
| 'type': 'toolitem', | ||
| 'text': _UNO('.uno:AddName', 'spreadsheet'), | ||
| 'command': '.uno:AddName', | ||
| 'accessibility': { focusBack: true, combination: 'DD', de: null } |
There was a problem hiding this comment.
@gokaysatir do we need to always put de: null ?
There was a problem hiding this comment.
@eszkadev no we shouldn't need that. I had put them as a placeholder in the first implementation. Because many of them were subject to change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.