Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing buttons for consistency #10136

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+33 −0
Open

Added missing buttons for consistency #10136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da2442e
calc: add database range menu entries in compact view
Rash419 Sep 26, 2024
669185b
calc: added named range entries in tabbed view 'Data' tab
Rash419 Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions browser/src/control/Control.Menubar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,9 @@ L.Control.Menubar = L.Control.extend({
{name: _UNO('.uno:NamesMenu', 'spreadsheet'), type: 'menu', menu: [
{name: _UNO('.uno:AddName', 'spreadsheet'), uno: '.uno:AddName'},
{name: _UNO('.uno:DefineName', 'spreadsheet'), uno: '.uno:DefineName'}]},
{name: _UNO('.uno:DefineDBName', 'spreadsheet'), uno: '.uno:DefineDBName'},
{name: _UNO('.uno:SelectDB', 'spreadsheet'), uno: '.uno:SelectDB'},
{name: _UNO('.uno:DataAreaRefresh', 'spreadsheet'), uno: '.uno:DataAreaRefresh'},
{type: 'separator'},
{name: _UNO('.uno:GroupOutlineMenu', 'spreadsheet'), type: 'menu', menu: [
{uno: '.uno:Group'},
Expand Down
30 changes: 30 additions & 0 deletions browser/src/control/Control.NotebookbarCalc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1832,6 +1832,36 @@ L.Control.NotebookbarCalc = L.Control.NotebookbarWriter.extend({
],
'vertical': 'true'
},
{
'type': 'container',
'children': [
{
'type': 'toolbox',
'children': [
{
'id': 'data-add-name',
'type': 'toolitem',
'text': _UNO('.uno:AddName', 'spreadsheet'),
'command': '.uno:AddName',
'accessibility': { focusBack: true, combination: 'DD', de: null }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gokaysatir do we need to always put de: null ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eszkadev no we shouldn't need that. I had put them as a placeholder in the first implementation. Because many of them were subject to change.

}
]
},
{
'type': 'toolbox',
'children': [
{
'id': 'data-define-name',
'type': 'toolitem',
'text': _UNO('.uno:DefineName', 'spreadsheet'),
'command': '.uno:DefineName',
'accessibility': { focusBack: true, combination: 'NN', de: null }
}
]
}
],
'vertical': 'true'
},
];

return this.getTabPage('Data', content);
Expand Down
Loading