net::Defaults: Revert and re-apply revised code #10366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgothel
force-pushed
the
private/sgothel/socketcode_netdefaults
branch
from
542ccd0
to
9372993
Compare
sgothel
changed the title
sgothel
force-pushed
the
private/sgothel/socketcode_netdefaults
branch
from
9372993
to
abb824d
Compare
5 tasks
caolanm
reviewed
Oct 30, 2024
sgothel
force-pushed
the
private/sgothel/socketcode_netdefaults
branch
from
abb824d
to
03efded
Compare
|
revised Socket.cpp include change (force push) |
ravin00
approved these changes
Oct 30, 2024
5 tasks
|
Cypress desktop failures:
|
sgothel
force-pushed
the
private/sgothel/socketcode_netdefaults
branch
from
03efded
to
022ef5b
Compare
added 2 commits
November 1, 2024 09:02
…tions (timeout)" This reverts commit 4499e42. Due to the removal of net::Defaults, the following global constexpr where introduced to keep functionality - SocketPoll:DefaultInactivityimeoutMicroS (3600s) - replaces of using DefaultPollTimeoutMicroS for {idle->inactivity) checkRemoval - SocketPoll:DefaultMaxTCPConnections (200000) - for limiting TCP connections in SocketPoll::poll, instead of using the session count - will be revised using system values in subsequent commit Signed-off-by: Sven Göthel <[email protected]> Change-Id: I5172b4067598c02678dd0cd2f56c0574013623d1
Using runtime mutable defaults for network properties allows us to test the connection limitation code. Costs are removal of constexpr properties, using a global instance, hence rendering the code less optimized and more pessimistic. Signed-off-by: Sven Göthel <[email protected]> Change-Id: I5172b4067598c02678dd0cd2f56c0574013623d1
caolanm
force-pushed
the
private/sgothel/socketcode_netdefaults
branch
from
022ef5b
to
0b72b96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
net::Defaults was a singleton, becoming a global, keeping untouched constexpr in SocketPoll.
instead of using the session count
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay