Skip to content

Feat add cellRenderer #2942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Wroud wants to merge 17 commits into from
Closed

Feat add cellRenderer #2942

Wroud wants to merge 17 commits into from

Conversation

@Wroud
Copy link
Contributor

@Wroud Wroud commented Jun 29, 2022

@Wroud
Copy link
Contributor Author

Wroud commented Apr 17, 2023

This pr will fix small issue with losing className prop, it's also implement more gained control over table rendering
please take a look

amanmahajan7
amanmahajan7 reviewed Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@amanmahajan7 amanmahajan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need tests for the renderCell prop

@codecov
Copy link

codecov bot commented Sep 12, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.24%. Comparing base (b75158a) to head (333d30f).

❗ Current head 333d30f differs from pull request most recent head 1509ffc

Please upload reports for the commit 1509ffc to get more accurate results.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2942       +/-   ##
===========================================
- Coverage   98.21%   83.24%   -14.98%     
===========================================
  Files          47       47               
  Lines        5098     4953      -145     
  Branches      724      763       +39     
===========================================
- Hits         5007     4123      -884     
- Misses         91      830      +739
Files Coverage Δ
src/Cell.tsx 93.93% <100.00%> (-6.07%) ⬇️
src/DataGrid.tsx 88.34% <100.00%> (-11.01%) ⬇️
src/Row.tsx 96.58% <100.00%> (-3.42%) ⬇️
src/index.ts 100.00% <100.00%> (ø)

... and 34 files with indirect coverage changes

@Wroud Wroud requested a review from amanmahajan7 September 12, 2023 15:43
amanmahajan7
amanmahajan7 reviewed Sep 17, 2023
View reviewed changes
@Wroud Wroud requested a review from amanmahajan7 September 20, 2023 19:30
@Liooo
Copy link
Contributor

Liooo commented Oct 16, 2024

@amanmahajan7 @nstepien @Wroud

What's the status on this PR?
I'd love this feature, I'm happy to do the rest of work if there's anything left.

This was referenced Oct 16, 2024
Closed
Merged
amanmahajan7 pushed a commit that referenced this pull request Nov 11, 2024
@Liooo @Wroud @sergeyteleshev
Feat add cellRenderer (successor of #2942) (#3621)
ff441ba 
* Feat cell renderer

* chore: rename cellRenderer -> renderCell

* chore: codestyle

* chore: add renderCell tests and readme

* chore: pr review fixes

* fix typo

* Refactor setupProvider function signature in renderers.test.tsx

* fix typing

* allow passing style to cellRenderer

* use object spread operator

---------

Co-authored-by: Aleksey Potsetsuev <[email protected]>
Co-authored-by: sergeyteleshev <[email protected]>
@amanmahajan7
Copy link
Collaborator

amanmahajan7 commented Nov 11, 2024

Completed in #3621

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nstepien nstepien Awaiting requested review from nstepien nstepien is a code owner

@amanmahajan7 amanmahajan7 Awaiting requested review from amanmahajan7 amanmahajan7 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Wroud @Liooo @amanmahajan7 @sergeyteleshev