Feat add cellRenderer (successor of #2942) #3621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* origin/main: Node 23 (Comcast#3618) Bump eslint-plugin-react-hooks from 4.6.2 to 5.0.0 (Comcast#3616) Implement download without `react-dom/server` (Comcast#3613) Bump @biomejs/biome from 1.8.3 to 1.9.3 (Comcast#3612)
Contributor
Author
|
Sorry for bothering, please take a look as it's almost there 🙏 |
Contributor
Author
|
ping @amanmahajan7 @nstepien plz 🙇🙇🙇 |
src/Cell.tsx
Outdated
| tabIndex={tabIndex} | ||
| className={className} | ||
| style={getCellStyle(column, colSpan)} | ||
| style={cellStyle} |
Collaborator
There was a problem hiding this comment.
Suggested change
| style={cellStyle} | |
| style={{ | |
| ...getCellStyle(column, colSpan), | |
| ...style | |
| }} |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3621 +/- ##
==========================================
- Coverage 91.56% 91.06% -0.51%
==========================================
Files 48 48
Lines 3440 3458 +18
Branches 690 677 -13
==========================================
- Hits 3150 3149 -1
- Misses 290 309 +19
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a successor of #2942, as it's not looking active anymore.
The following 3 commits are added from the original PR:
stylefor cellRendererThe reason behind the 3rd commit is, it was necessary to accomplish animated row reordering using https://github.com/clauderic/dnd-kit like below (this is my specific usecase but it should be useful in other scenarios as well):