-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an extended number widget with support for annotations #994
base: main
Are you sure you want to change the base?
Conversation
Type checking is satisfied aside from the forced widget type Widgets defined in python code as INT or FLOAT are now converted if the options includes relevant keys. This grants functionality similar to the multiline option on strings Colors now correctly follow themes
Naming now uniformly refers to the widget as an Annotated Number and the widget is now implemented as a proper typescript class annotatedNumber widgets can optionally have an annotation function set. This allows for extensions to set annotations on ranges of values. Fixed the app import incorrectly having an extension
This would be very useful. For instance, I would prefer to reset to a cfg of 7.0 instead of 8.0 Maybe a right click node option to |
Button placement is my greatest undertainty. I was strongly considering moving it to be between the left arrow and the option name, but I quite like your suggestion. I had not considered letting end users configure defaults, but I can see it being quite useful. I imagine it's better to have a user configured default be tied to node type instead of a node instance, so it would likely be implemented as part of user state. I'll look into it, but it's probably best pushed to a subsequent pull request. |
@AustinMroz if you're making things configurable, is there any chance you could implement #594 while there? I don't really have the frontend skills to do it myself, but since litegraph already has a property system, it sounds like a possible place to store any user overrides for value widgets. As for the button placement, I think you'll want to put them somewhere where they don't really move around depending on text lengths for example (so on the right should be fine); that'll make their position easier to predict. |
Hmmm. I need to ponder it more, but my initial thoughts is that it would be overly problematic
|
@asagi4, you could try this extension: https://github.com/chrisgoringe/cg-controller ( It's from the same developer of https://github.com/chrisgoringe/cg-use-everywhere ) It allows you to mirror any node into dockable windows. It uses sliders for number widgets. And once you edit a slider, the original widget will use the same parameters, in the node's graph. |
I actually have that, but I had no idea editing steps was a feature. That solves my problem, though I think it would be a useful feature to have without extensions too. |
Frequently, number widgets will have values with special meaning, but these values are not always intuitive. For example, setting cfg to 1.0 disables it even though cfg can be set to less than 1.
This adds three additional options to FLOAT and INT inputs. If any of these is present, the widget is converted to an annotatedNumber on node creation, similar to how multiline string inputs function.
reset
adds a button to the side to the side of the node to reset it to some chosen value. This does not need to be the same as thedefault
value.disable
similarly, adds a button to set the widget to quickly select a value that disables the widgets associated action. If both disable and reset are assigned values, reset takes priority and disable is only shown when the value is already at the assigned reset valuemappedValues
is a map of potential widget values to strings. When the widget is assigned to the chosen value, the given string is displayed next to it.While the implementation is currently functional, the design is tentative and feedback is appreciated.