Radiation plugin: Workaround BP5 bug #4399
Merged
+7
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franzpoeschel
force-pushed
the
fix-radiation-bp5
branch
2 times, most recently
from
5878297
to
25eb278
Compare
psychocoderHPC
added
bug
|
@franzpoeschel great catch |
The Radiation plugin sets some attributes quite late. This is normally supported by the openPMD-api, but can become a bit tricky, when the attribute is a default attribute with a default value. The Radiation plugin uncovers a bug in (depending on your point of view) either openPMD-api or in ADIOS2 with this procedure in the BP5 engine. Realistically the best fix for this would be to set defaults in the openPMD-api as late as possible, and not as early as possible. For now, defining these attributes as early as possible in the Radiation plugin is a sensible workaround.
franzpoeschel
force-pushed
the
fix-radiation-bp5
branch
from
25eb278
to
1570986
Compare
PrometheusPi
approved these changes
Dec 20, 2022
psychocoderHPC
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the BP5 engine, the Radiation plugin currently creates unreadable files:
The Radiation plugin sets some attributes quite late. This is normally supported by the openPMD-api, but can become a bit tricky, when the attribute is a default attribute with a default value. The Radiation plugin uncovers a bug in (depending on your point of view) either openPMD-api or in ADIOS2 with this procedure in the BP5 engine. Realistically the best fix for this would be to set defaults in the openPMD-api as late as possible, and not as early as possible (see the corresponding item in openPMD/openPMD-api#1332). For now, defining these attributes as early as possible in the Radiation plugin is a sensible workaround.
TODO: