Fix infinite ADK rates #5206
Open
Fix infinite ADK rates #5206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianMarre
force-pushed
the
topic-fixInfiniteADKRates
branch
4 times, most recently
from
731f98c
to
fe87026
Compare
psychocoderHPC
added
bug
BrianMarre
force-pushed
the
topic-fixInfiniteADKRates
branch
4 times, most recently
from
d612faf
to
81972cd
Compare
psychocoderHPC
requested changes
Nov 13, 2024
| updateTimeRemaining(mappingDesc); | ||
| isSubSteppingComplete = isSubSteppingFinished(mappingDesc, deviceLocalReduce); | ||
| } // end atomicPhysics sub-stepping loop | ||
|
|
||
| // ensure no unbound states are visible to the rest of the loop | ||
| doIPDIonization(mappingDesc, currentStep, deviceLocalReduce); |
There was a problem hiding this comment.
Does the mean we execute the IPD ionization twice per pic time step? Because we call this already in line 540.
There was a problem hiding this comment.
yes, that is intended and necessary.
The second call of doIPDIonization is necessary here since we need to make sure that we do not pass an unbound state with a too low charge state to the pusher and we need to call doIPDIonization again at the beginning of the next AtomicPhyiscs step since the we updated the field in between causing a possible change result of the call.
Also note calling doIPDIonization twice on the same particle set with an unchanged E-Field does not change particle set anymore after the first call.
previously did not consider excitation in the ionization energy calcualtion in the ApplyIPDIonization kernel ci: picongpu
this avoids very high to ADK rates due to BSI unbound states being still present ci: picongpu
BrianMarre
force-pushed
the
topic-fixInfiniteADKRates
branch
from
81972cd
to
9edf73f
Compare
This was referenced Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes an infinite loop in the AtomicPhysics FLYonPIC stage due to a numerical underflow of the atomicPhysics timestep due to very high ADK rates of BSI unbound states still being present, by moving the Removal of IPD unbound states before the filling of the rate cache.